Refactor: Unified context-management architecture with improved UX #9795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XXL
Contributor
Re-review for commit 51aeabc is complete; context-management threshold handling is now centralized and covered by tests, with no net new issues identified in this update.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
hannesrudolph
force-pushed
the
feature/unified-context-management
branch
from
ce8f7e4 to
4384ed0
Compare
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
mrubens
reviewed
Dec 6, 2025
mrubens
reviewed
Dec 6, 2025
mrubens
reviewed
Dec 6, 2025
- Consolidate all context-management UI into single module - Add type-safe exhaustiveness checking with assertNever - Make in-progress indicators visible for both automatic and forced context management - Add UI for sliding window truncation (previously silent) - Improve test coverage with comprehensive component tests - Use consistent codicon-fold icon across all context management events - Fix translation key references to use proper namespaced keys - Remove unused code and improve error handling
- Consolidate contextCondense and contextManagement into unified structure
- Move shared 'tokens' key to top-level contextManagement
- Rename 'condensing' to 'inProgress' for consistency with truncation
- Update all component references to use new translation keys
- Update test mocks with new translation structure
Benefits:
- Clear hierarchical structure: contextManagement > {condensation, truncation}
- Consistent naming: both operations have 'inProgress' state
- Eliminates cross-section references (truncation using condense keys)
- Easier to extend with new context management strategies
- Update all 17 language files to use new unified structure - Move from split contextCondense/contextManagement to single contextManagement - Apply consistent naming: condensation.inProgress and truncation.inProgress - All languages now follow same hierarchical structure - Verified with find-missing-translations.js: all complete Languages updated: ca, de, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW
This file is marked as deprecated and has been fully replaced by the new unified context-management module. Removing it resolves the knip check failure.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Contributor
Updated PR description to match the actual code implementation. Key changes:
|
mrubens
approved these changes
Dec 7, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds UI visibility for context management events (condensation and truncation) that were previously hidden from users.
Changes
User-Facing Impact
In-Progress Indicator for Context Management
Sliding Window Truncation Visibility
UI Consistency
FoldVerticalicon from lucide-react for visual consistency with condense buttonBackend Coordination
Task.tssignals context management lifecycle:condenseTaskContextStarted→ Enables in-progress UImanageContext()runs (condensation or truncation)condenseTaskContextResponse→ Clears in-progress stateNew
willManageContext()helper centralizes threshold logic to avoid duplication between Task.ts and manageContext().Architecture
Context management events handled directly in
ChatRow.tsxswitch cases with focused child components:InProgressRow- Shows spinner during context operationsCondensationResultRow- Shows condensation summary with token reduction and expandable summaryCondensationErrorRow- Shows error when condensation failsTruncationResultRow- Shows truncation details with messages removed countType System
New
packages/types/src/context-management.ts:CONTEXT_MANAGEMENT_EVENTSarray of event typesContextManagementEventunion typeisContextManagementEvent()type guard for runtime checkingExtended
ContextTruncationtype withnewContextTokensfield.Test Coverage
packages/types/src/__tests__/context-management.test.tswillManageContext()insrc/core/context-management/__tests__/ChatView.spec.tsx