Skip to content

Exclude the ID from Roo reasoning details #9847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 1 commit into from
Dec 5, 2025
Merged

Exclude the ID from Roo reasoning details #9847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/api/providers/roo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
text?: string
summary?: string
data?: string
id?: string | null
format?: string
Copy link
Contributor

@roomote roomote bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency: The id field was removed from reasoning details in roo.ts but the same field still exists in openrouter.ts at lines 237, 265, 290, and 300. For consistency, the id field should also be removed from openrouter.ts since both providers handle reasoning_details in the same way and this PR's goal is to exclude the ID from reasoning details.

Fix it with Roo Code or mention @roomote and request a fix.

Copy link
Collaborator Author

@mrubens mrubens Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the openrouter provider has the same problem

signature?: string
index?: number
Expand All @@ -194,7 +193,6 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
existing.data = (existing.data || "") + detail.data
}
// Update other fields if provided
if (detail.id !== undefined) existing.id = detail.id
if (detail.format !== undefined) existing.format = detail.format
if (detail.signature !== undefined) existing.signature = detail.signature
} else {
Expand All @@ -204,7 +202,6 @@ export class RooHandler extends BaseOpenAiCompatibleProvider<string> {
text: detail.text,
summary: detail.summary,
data: detail.data,
id: detail.id,
format: detail.format,
signature: detail.signature,
index,
Expand Down
Loading