fix: add preserveReasoning flag to Kimi and MiniMax reasoning models #9907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add moonshot.kimi-k2-thinking with 32K max tokens and 256K context - Add minimax.minimax-m2 with 16K max tokens and 230K context - Add qwen.qwen3-next-80b-a3b with 8K max tokens and 262K context - Add qwen.qwen3-coder-480b-a35b-v1:0 with 8K max tokens and 262K context All models configured with native tool support and appropriate pricing. Fixes #9902
Contributor
Author
Review complete. No issues found. The changes correctly add the Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
Contributor
Author
|
Closing this PR as requested. The changes will be made to #9905 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9902 by adding the
preserveReasoning: trueflag to the Kimi and MiniMax models.Context
As reported by @jbearak, the Kimi and MiniMax models are reasoning models that output thinking traces. Without the
preserveReasoningflag, Roo does not properly recognize task completion for these models.Changes
preserveReasoning: truetomoonshot.kimi-k2-thinkingmodel configurationpreserveReasoning: truetominimax.minimax-m2model configurationThis ensures that:
Testing
npm run buildin packages/types)npx vitest runin packages/types)Related Issues
Addresses feedback in #9902
Feedback and guidance are welcome!