feat: add API error telemetry to OpenRouter provider #9953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ApiError: Expected toolResult blocks for mismatched IDs ## Problem Tool_result blocks sometimes had incorrect tool_use_id values, causing the Anthropic API to reject requests with errors like: "Expected toolResult blocks at messages.6.content for the following Ids: toolu_ABC, but found: toolu_XYZ" ## Solution Added centralized validation in addToApiConversationHistory() that: - Validates tool_result IDs against tool_use IDs from previous assistant message - Fixes mismatches using position-based matching - Logs warnings for debugging when corrections are made ## Changes - Added src/core/task/validateToolResultIds.ts with validation logic - Added src/core/task/__tests__/validateToolResultIds.spec.ts (12 tests) - Modified src/core/task/Task.ts to call validation - Simplified src/core/assistant-message/presentAssistantMessage.ts by removing redundant source-level validation
dosubot
bot
added
size:L
Contributor
Review complete. No new issues found. The latest commit (ba3c0ce) reverts the unrelated tool_result ID validation changes that were accidentally included from #9952. This addresses the reviewer feedback. The revert is clean and correctly removes the Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
cte
approved these changes
Dec 9, 2025
hannesrudolph
added
the
Issue/PR - Triage
cte
reviewed
Dec 9, 2025
cte
approved these changes
Dec 9, 2025
mrubens
reviewed
Dec 9, 2025
Collaborator
There was a problem hiding this comment.
Should we use the posthog error handling instead of just events? https://posthog.com/docs/error-tracking
- Replace .slice().reverse().find() with direct backwards loop - Avoids creating two intermediate arrays for large conversation histories - Applied to both addToApiConversationHistory and flushPendingToolResultsToHistory
- Replace manual backwards loop with findLastIndex in both addToApiConversationHistory and flushPendingToolResultsToHistory - Improves clarity and consistency with existing code patterns
- Add new TelemetryEventName.API_ERROR to telemetry types - Log API errors to PostHog with sanitized error messages - Use sanitizeErrorMessage to redact sensitive info (URLs, paths, IPs, emails) - Add tests for telemetry capture in error scenarios
- Add EXPECTED_API_ERROR_CODES and shouldReportApiErrorToTelemetry to types package - Filter out 429 rate limit errors from telemetry (expected behavior) - Add tests to verify 429 errors don't trigger telemetry
daniel-lxs
force-pushed
the
feat/openrouter-api-error-telemetry
branch
from
5b144be to
0d0ab5d
Compare
dosubot
bot
added
size:XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add API error telemetry to the OpenRouter provider using PostHog's
captureExceptionfor structured error tracking.Changes
ApiProviderErrorgeneric error class in@roo-code/typesfor structured error tracking via PostHog (can be reused by other providers)createMessagemethod (both SDK errors and streaming errors)completePromptmethod (both SDK errors and response errors)shouldReportApiErrorToTelemetry()to filter out expected errors like 429 rate limitsDepends on
captureExceptionto TelemetryService)Test plan