Fix roon API test app for latest browser WebSocket and Roon API changes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add polyfills for the native WebSocket browser implementation to be compatible with nodejs ws methods that the Roon API library uses * Add periodic reconnect (every 8 seconds) to get around disconnect every 10 seconds due to inability of browser WebSocket to send a Ping often enough. Unfortunately there is not a solution to this without changing the Roon API behavior. Works fine with these changes and is actually a great app for Roon; however the view flashes every 8 seconds. See issue RoonLabs/node-roon-api#34 for core issue with roon js API using non-native WebSocket methods. Though, it is billed as a "node roon API" so not sure if that's in scope.
dannydulai
reviewed
Jul 17, 2023
| @@ -1,2 +1,5 @@ | |||
| node_modules | |||
| bundle.js | |||
| .cache/ | |||
| package-lock.json | |||
There was a problem hiding this comment.
this is not a good thing to add... package-lock.json should always be committed.
|
what browsers is this not compatible with? |
|
(Sorry for the notification spam, wrong github account) @dannydulai it's been a while since I looked at this but as I had tested, it was the latest rolling release of Chrome that it was not working with. I expect there are differences between node.js's implementation of websockets and nearly all browser-based implementations. I can test again and with other browsers and report back, but the general conclusion is the code in master isn't compatible with modern browsers as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works fine with these changes and is actually a great app for Roon;
however the view flashes every 8 secondsand works perfectly smoothly to boot.See issue RoonLabs/node-roon-api#34 for core issue with roon js API using non-native WebSocket methods. Though, it is billed as a "node roon API" so not sure if that's in scope.