Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build.rs Change Detection Should be Directory Based #193

Open
Carter12s opened this issue Aug 14, 2024 · 0 comments
Open

Build.rs Change Detection Should be Directory Based #193

Carter12s opened this issue Aug 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Carter12s
Copy link
Collaborator

If the path points to a directory, it will scan the entire directory for any modifications.

Currently our recommend approach to message generation is the build.rs file in example-package. However, this does not automatically detect NEW message files being added to the ROS search paths.

https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed

Says that if we emit folders instead of specific files, cargo will re-run if "any" modification occurs.

We should test this behavior and if it does what it says on the side of the box, we should switch to specifying paths.

ALSO (maybe a different issue):

https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-env-changed <- allows us to trigger message generation if ROS_PACKAGE_PATH is changed...

@Carter12s Carter12s added the enhancement New feature or request label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant