Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ground connections for loads, sources and transformers #327

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

alihamdan
Copy link
Member

No description provided.

@alihamdan alihamdan added the enhancement New feature or request label Feb 3, 2025
@alihamdan alihamdan self-assigned this Feb 3, 2025
roseau/load_flow/models/grounds.py Outdated Show resolved Hide resolved
@Saelyos
Copy link
Collaborator

Saelyos commented Feb 3, 2025

I'm wondering about the global design of ground connections, as the changes in this PR do not address connections with impedances easily.

Could a Connection object be a good design ? It would have an internal C++ object, and it also allows to have disconnection and results getter.

Something like

con = Connection(bus, ground)   # or con = Connection(bus, ground, z=01+01j)

# network creation, solving...

current = con.res_current  # Current flowing through the ground connection

con.disconnect()  # Same as load.disconnect(), the connection isn't used anymore

@alihamdan alihamdan marked this pull request as draft February 4, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants