New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible misleading comment. #42

Open

zackmawaldi opened this issue Dec 6, 2022 · 1 comment

Member

zackmawaldi commented Dec 6, 2022

RFDesign/hallucination/hallucinate.py

Line 109 in bba6992

# loss functions: =1 to turn off, 0 to calculate but not optimize on

RFDesign/hallucination/loss.py

Line 680 in bba6992

def add(self, name, loss_func, weight=1.):

Looking at how the code works, seems like -1 is to turn off, not 1. That's unless I'm understanding the code wrong (which is possible!).

Collaborator

jueseph commented Dec 6, 2022 via email

Yes, you're right, there is a typo in the comment. It seems there is an equals sign where a minus/hyphen should be.

On Tue, Dec 6, 2022 at 11:24 AM zack ***@***.***> wrote: https://github.com/RosettaCommons/RFDesign/blob/bba6992283de63faba6ff727bb4bc68327a5356c/hallucination/hallucinate.py#L109 https://github.com/RosettaCommons/RFDesign/blob/bba6992283de63faba6ff727bb4bc68327a5356c/hallucination/loss.py#L680 Looking at how the code works, seems like -1 is to turn off, not 1. That's unless I'm understanding the code wrong (which is possible!). — Reply to this email directly, view it on GitHub <#42>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABCU5YMTIPXOTXSDOBUXPDWL6HIJANCNFSM6AAAAAASV4YMPE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment