Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LinaAitIder #24

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Conversation

LinaAitIder
Copy link
Contributor

Hello ,

Screenshots :

image
image

  • I have added a screenshot from browser with my changes
  • There are no errors in the console
  • I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(^◡^)۶
  • There are some things I'd like to improve in this tutorial. I have written them below.

Changes

In the Read Me file, we only include changes made to the HTML page in the contributors folder. However, changes to the JavaScript script are omitted, which prevents contributors from being reflected on the main page. Instead of using git add contributors/<your-github-id>.html, it would be better to use git add . to ensure all changes are included.

Thank you for giving us an opportunity to contribute 🙂

@Roshanjossey Roshanjossey merged commit 00daa9b into Roshanjossey:main Feb 16, 2025
@Roshanjossey
Copy link
Owner

Thank you for your feedback @LinaAitIder.

Instruction to only add html file is intentional. We build contributors.js file during build process.

You can see that I removed your change in contributors.js in this PR but still it is there in https://roshanjossey.github.io/code-contributions/

@LinaAitIder
Copy link
Contributor Author

Thank you @Roshanjossey for the clarification! I see now that the contributors.js file is generated during the build process, which makes sense. I hadn’t considered that before, and I realize I have a lot to learn about how build processes work. I really appreciate the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants