Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dev-rygar #30

Merged
merged 1 commit into from
Feb 19, 2025
Merged

add dev-rygar #30

merged 1 commit into from
Feb 19, 2025

Conversation

dev-rygar
Copy link
Contributor

@dev-rygar dev-rygar commented Feb 18, 2025

Before submitting this pull request, please go through the checklist below.
If you're doing something in the checklist, put an x inside [ ] so that - [ ] becomes - [x]

  • I have added a screenshot from browser with my changes
  • There are no errors in the console
  • I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(^◡^)۶
  • [x ] There are some things I'd like to improve in this tutorial. I have written them below.

I would like to note that "adding screenshot from browser with my changes" is not included in the instruction, also part of the instruction about editing "contributor.js" was part of the instruction but it was not instructed to include it at "git add contributors/.html" part.

Issue/concern:

  • adding screenshot was not part of the instruction
  • editing and adding my/your html file name at contributors.js was part of the process but not part of "git add"

reference for instructions: https://github.com/Roshanjossey/code-contributions/blob/main/docs/CONTRIBUTING.md

@Roshanjossey Roshanjossey merged commit 361364b into Roshanjossey:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants