Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live toggling #30

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Live toggling #30

merged 1 commit into from
Nov 16, 2022

Conversation

holantomas
Copy link
Contributor

Github just closed old PR, because I had to sync my fork for testing. There is synced source from last PR - nothing was added.

@holantomas
Copy link
Contributor Author

BTW now I see why did you complain ... Github diff did just one big mess. There are not so big changes. I just add/changed few lines and add some new functions, renamed class name cause you did take one from VerticalStackCard and I don't know if there can be some conflicts(and it looks better). As last thing I removed first line which was there for nothing, it just print in browser console wrong component version. If you want to see, open in some better diff.

@holantomas holantomas mentioned this pull request Nov 16, 2022
@andrzejl
Copy link
Contributor

I noticed that changed file use DOS line endings. Your commit probably also fixed whitespaces. If you want to see only significant changes you can always use Hide whitespace option:
image
When it is turned on the diff looks much cleaner.

@holantomas
Copy link
Contributor Author

@andrzejl yeah, my IDE doing this by default settings(both - hodině whitespace changes and auto-fix them) 😁. I'm used to use all kind of QA, lints, etc. This developing by scratch is new for me 😁

@RossMcMillan92
Copy link
Owner

Thank you my friend, let's get it in

@RossMcMillan92 RossMcMillan92 merged commit e582f21 into RossMcMillan92:main Nov 16, 2022
@holantomas
Copy link
Contributor Author

@RossMcMillan92 thanks, I'm going to sync my last modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants