Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated Javascript files #634

Closed
marco-brandizi opened this issue Apr 13, 2022 · 3 comments
Closed

Duplicated Javascript files #634

marco-brandizi opened this issue Apr 13, 2022 · 3 comments
Labels
bug project:client Related to the client/front-end war. project:web service Knetminer web service (ws), including search, JSON out, data export, config reading.

Comments

@marco-brandizi
Copy link
Member

marco-brandizi commented Apr 13, 2022

Javascript directories loginHandler/ and saveKnetwork/ are duplicated in both client-base and server-base. That's a poor way to develop software, we need to

  1. clarify if we need these files on both sides (ie, why on the server?)
  2. Depending on 1) delete the duplicates or re-arrange Maven to make copies during the build. Ideally, create them as a NPM Javascript repository and include them in KnetMiner using NPM dependency mechanisms (ie, package.json, git URL refs and the like).
@marco-brandizi marco-brandizi added bug project:web service Knetminer web service (ws), including search, JSON out, data export, config reading. project:client Related to the client/front-end war. labels Apr 13, 2022
@Arnedeklerk
Copy link
Member

@manlikleo is this complete?

@marco-brandizi
Copy link
Member Author

This is almost complete. We still need:

  1. to remove the duplicated files from the server app
  2. to upgrade the /genepage URLs on the knetminer.com proxy, so that existing URLs go to the new URL on the client app

Let's leave this opened until the above points are done.

@Arnedeklerk
Copy link
Member

@marco-brandizi @lawal-olaotan please close if done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug project:client Related to the client/front-end war. project:web service Knetminer web service (ws), including search, JSON out, data export, config reading.
Projects
None yet
Development

No branches or pull requests

2 participants