Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene table view, Evidence detail box doesn't work anymore #777

Open
marco-brandizi opened this issue Jul 17, 2023 · 4 comments
Open

Gene table view, Evidence detail box doesn't work anymore #777

marco-brandizi opened this issue Jul 17, 2023 · 4 comments
Assignees
Labels
bug project:client Related to the client/front-end war.

Comments

@marco-brandizi
Copy link
Member

marco-brandizi commented Jul 17, 2023

When showing the gene table, if I click on one of the icon in the Evidence column, a box is shown that has links to PUBMED in case of publications, something else I don't remember for the other cases (Network view?):

The links don't work anymore, they raise this error:

evidence-table.js:758 Uncaught TypeError: Cannot read properties of undefined (reading 'replace')
    at toggleEvidencePopUp (evidence-table.js:758:45)
    at HTMLDivElement.<anonymous> (gene-table.js:467:5)
    at HTMLDivElement.dispatch (jquery-bstrap.min.js:32:39900)
    at v.handle (jquery-bstrap.min.js:32:36635)

I doubt this was caused by today's changes about #743, since the affected code hasn't changed (as far as I can see). In the 5.6 release, this looks disabled (eg, https://knetminer.com/cereals). @KeywanHP, do we still want this?

EDIT: maybe it's caused by the fact that the open/close click handler takes over the whole box (if I click on a corner, the box closes), so, when I attempt to click the box contents (a concept type, a concept label, a PubMed link), that click handler still attempts to find the box ID to close from the child element (which hasn't any ID).

@KeywanHP
Copy link
Member

Yes we decided to keep it. It's a useful feature. However, the popup could benefit from a small make-over. We could show the new "graphDistance" property in the popup to make it even more useful! @marco-brandizi @marco-brandizi @lawal-olaotan @Arnedeklerk

@Arnedeklerk
Copy link
Member

Yep, good idea...

@marco-brandizi
Copy link
Member Author

We could show the new "graphDistance" property in the popup to make it even more useful! @marco-brandizi @marco-brandizi @lawal-olaotan @Arnedeklerk

Nice, for the moment, let's make it working again :-)

@marco-brandizi marco-brandizi changed the title Gene table view, Evidence detail box doesn't work anymore. Gene table view, Evidence detail box doesn't work anymore Jul 17, 2023
marco-brandizi added a commit that referenced this issue Jul 18, 2023
@marco-brandizi
Copy link
Member Author

marco-brandizi commented Jul 18, 2023

@lawal-olaotan, it seems I've fixed it [REF]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug project:client Related to the client/front-end war.
Projects
None yet
Development

No branches or pull requests

4 participants