Issue #2637: Introduced behavior 'IsDropdownCapable' for reference fi…

…elds. Introduced 'ConstantValue' for field type settings. Both to restrict CustomerUser input type to autocomplete while maintaining field type settings structure.
RotherOSS · Dec 12, 2023 · b575906 · b575906
1 parent 8fdf7b3
commit b575906
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 7 deletions.
diff --git a/Kernel/Modules/AdminDynamicFieldReference.pm b/Kernel/Modules/AdminDynamicFieldReference.pm
@@ -303,11 +303,18 @@ sub _AddAction {
     SETTING:
     for my $Setting ( $Param{FieldTypeSettings}->@* ) {
 
+        my $Name = $Setting->{ConfigParamName};
+
+        # handle settings with a constant value
+        if ( $Setting->{ConstantValue} ) {
+            $FieldConfig{$Name} = $Setting->{ConstantValue};
+            next SETTING;
+        }
+
         # skip custom inputs which are handled separately
         # currently only used for reference filter list
         next SETTING if !$Setting->{InputType};
 
-        my $Name = $Setting->{ConfigParamName};
         $FieldConfig{$Name} = $GetParam{$Name};
     }
 
@@ -624,11 +631,18 @@ sub _ChangeAction {
     SETTING:
     for my $Setting ( $Param{FieldTypeSettings}->@* ) {
 
+        my $Name = $Setting->{ConfigParamName};
+
+        # handle settings with a constant value
+        if ( $Setting->{ConstantValue} ) {
+            $FieldConfig{$Name} = $Setting->{ConstantValue};
+            next SETTING;
+        }
+
         # skip custom inputs which are handled separately
         # currently only used for reference filter list
         next SETTING if !$Setting->{InputType};
 
-        my $Name = $Setting->{ConfigParamName};
         $FieldConfig{$Name} = $GetParam{$Name};
     }
 

diff --git a/Kernel/System/DynamicField/Driver/Agent.pm b/Kernel/System/DynamicField/Driver/Agent.pm
@@ -84,6 +84,7 @@ sub new {
         'IsCustomerInterfaceCapable'   => 1,
         'IsHiddenInTicketInformation'  => 0,
         'IsReferenceField'             => 1,
+        'IsDropdownCapable'            => 1,
     };
 
     $Self->{ReferencedObjectType} = 'Agent';

diff --git a/Kernel/System/DynamicField/Driver/BaseReference.pm b/Kernel/System/DynamicField/Driver/BaseReference.pm
@@ -851,8 +851,9 @@ sub GetFieldTypeSettings {
             };
     }
 
-    # set up the edit field mode selection
-    {
+    if ( $Self->{Behaviors}{IsDropdownCapable} ) {
+
+        # set up the edit field mode selection
         push @GenericSettings,
             {
                 ConfigParamName => 'EditFieldMode',
@@ -866,10 +867,8 @@ sub GetFieldTypeSettings {
                 },
                 PossibleNone => 0,
             };
-    }
 
-    # add possible none option
-    {
+        # add possible none option
         push @GenericSettings,
             {
                 ConfigParamName => 'PossibleNone',

diff --git a/Kernel/System/DynamicField/Driver/CustomerCompany.pm b/Kernel/System/DynamicField/Driver/CustomerCompany.pm
@@ -83,6 +83,7 @@ sub new {
         'IsCustomerInterfaceCapable'   => 1,
         'IsHiddenInTicketInformation'  => 0,
         'IsReferenceField'             => 1,
+        'IsDropdownCapable'            => 1,
     };
 
     $Self->{ReferencedObjectType} = 'CustomerCompany';

diff --git a/Kernel/System/DynamicField/Driver/CustomerUser.pm b/Kernel/System/DynamicField/Driver/CustomerUser.pm
@@ -83,6 +83,7 @@ sub new {
         'IsCustomerInterfaceCapable'   => 1,
         'IsHiddenInTicketInformation'  => 0,
         'IsReferenceField'             => 1,
+        'IsDropdownCapable'            => 0,
     };
 
     $Self->{ReferencedObjectType} = 'CustomerUser';
@@ -103,6 +104,13 @@ sub GetFieldTypeSettings {
         %Param,
     );
 
+    # always set editfieldmode to autocomplete
+    push @FieldTypeSettings,
+        {
+            ConfigParamName => 'EditFieldMode',
+            ConstantValue   => 'AutoComplete',
+        };
+
     # Support reference filters
     push @FieldTypeSettings,
         {

diff --git a/Kernel/System/DynamicField/Driver/Ticket.pm b/Kernel/System/DynamicField/Driver/Ticket.pm
@@ -85,6 +85,7 @@ sub new {
         'IsCustomerInterfaceCapable'   => 1,
         'IsHiddenInTicketInformation'  => 0,
         'IsReferenceField'             => 1,
+        'IsDropdownCapable'            => 1,
     };
 
     $Self->{ReferencedObjectType} = 'Ticket';