Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation: check return code of the executed SQL statements #10

Closed
bschmalhofer opened this issue May 8, 2020 · 2 comments
Closed

Installation: check return code of the executed SQL statements #10

bschmalhofer opened this issue May 8, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

In Installer.pm there are SQL-statements first collected and then executed. However the return status of the execution is never inspecter. Thus the intstaller GUI might report everything as successful, even when some tables were not created.

TODO: inspect the return code and stop the installationj when there are errors
@svenoe
Copy link
Contributor

svenoe commented May 14, 2020

Agreed.

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Jul 1, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 1, 2020
bschmalhofer added a commit that referenced this issue Aug 7, 2020
@bschmalhofer
Issue #10: throw FatalError when the SQL statement fails.
48f3be8
bschmalhofer added a commit that referenced this issue Aug 7, 2020
@bschmalhofer
Merge pull request #333 from RotherOSS/issue-10-blast_from_the_past
9a32e0c 
Issue #10: throw FatalError when the SQL statement fails.
@bschmalhofer
Copy link
Contributor Author

Broke an INSERT in scripts/database/otobo-initial_insert.xml and got an error when running installer.pl.
That's the wanted result. Closing the issue.

@bschmalhofer bschmalhofer self-assigned this Nov 28, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
2 participants
@bschmalhofer @svenoe