Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionID is included twice in URL when Session cookies are turned off #1025

Closed
bschmalhofer opened this issue May 26, 2021 · 1 comment
Closed

SessionID is included twice in URL when Session cookies are turned off #1025

bschmalhofer opened this issue May 26, 2021 · 1 comment
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

This bug surfaced from the test script scripts/test/Selenium/Agent/Admin/AdminSystemConfigurationExampleSessionID.t . In the test script, the config setting SessionUseCookie is turned off. This means that the session id must be passed back and forth via the URL. The substitution in the URL was triggered successfully, but the substitution was broken. In the concrete case /otobo/index.pl? was turned into /index.pl?OTOBOAgentInterface=fm4MbP076eoOLgi3T279gFdz12rlAvaf?OTOBOAgentInterface=fm4MbP076eoOLgi3T279gFdz12rlAvaf'.

As these code for the substitution looked questionable anyways, I simply tidied the code without investigating why exactly the duplicated session id occured.
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label May 26, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone May 26, 2021
@bschmalhofer bschmalhofer self-assigned this May 26, 2021
bschmalhofer added a commit that referenced this issue May 26, 2021
@bschmalhofer
Issue #1025: simplify, and fix, code for adding SessionID in URL
7035b2b
bschmalhofer added a commit that referenced this issue May 26, 2021
@bschmalhofer
Issue #1025: tidying
3e431da
bschmalhofer added a commit that referenced this issue May 26, 2021
@bschmalhofer
Merge pull request #1026 from RotherOSS/issue-#1025-double_session_id
410f40d 
Issue #1025 double session
bschmalhofer added a commit that referenced this issue May 26, 2021
@bschmalhofer
Issue #1025: SessionID must be concatenated
8edf5da
bschmalhofer added a commit that referenced this issue May 26, 2021
@bschmalhofer
Issue #1025: try to simplify the Redirect() method
0333dbf
bschmalhofer added a commit that referenced this issue May 26, 2021
@bschmalhofer
Merge pull request #1028 from RotherOSS/issue-#1025-double_session_id
0e41edc 
Issue #1025 double session
@bschmalhofer
Copy link
Contributor Author

The test suite looks fine. Closing this issue.

@bschmalhofer bschmalhofer mentioned this issue May 26, 2021
Closed
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer