Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize changes to %ENV #1043

Closed
bschmalhofer opened this issue May 29, 2021 · 1 comment
Closed

Localize changes to %ENV #1043

bschmalhofer opened this issue May 29, 2021 · 1 comment
Assignees
Labels
bug Something isn't working as intended
Milestone

Comments

@bschmalhofer
Copy link
Contributor

In a persistent Perl environment, e.g. mod_perl or Gazelle, it is usually a good idea to localize changes to %ENV. See https://perl.apache.org/docs/general/perl_reference/perl_reference.html#The_Scope_of_the_Special_Perl_Variables . Luckily there already is a Perl::Critic check for this, but apparently this check often was deactivated to lightheartedly. So, look at the places where ## no critic qw(Variables::RequireLocalizedPunctuationVars) is in effect and investigate whether the changes to %ENV can be localised.

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label May 29, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone May 29, 2021
@bschmalhofer bschmalhofer self-assigned this May 29, 2021
bschmalhofer added a commit that referenced this issue May 29, 2021
The scripts still need to be tested seperately.
bschmalhofer added a commit that referenced this issue May 29, 2021
…unctuationVars

Issue #1043 require localized punctuation vars
@bschmalhofer
Copy link
Contributor Author

The test suite looks fine and CodePolicy has no complaints about Variables::RequireLocalizedPunctuationVars. The cgi-bin scripts will be tested later. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant