Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemention of ACLs for Subject, Body and Attachment #1058

Closed
OlliW opened this issue Jun 7, 2021 · 5 comments
Closed

Implemention of ACLs for Subject, Body and Attachment #1058

OlliW opened this issue Jun 7, 2021 · 5 comments
Labels
contribution Contribution from other parties - thank you! :) enhancement New feature or request
Milestone

Comments

@OlliW
Copy link

OlliW commented Jun 7, 2021

For further possibilities for the ticket creation with the CustomerTicketMessage (instead the CustomerTicketProcess) it is necessary to hidde or show the Subject, Body and Attachment Fields.

@svenoe svenoe added contribution Contribution from other parties - thank you! :) enhancement New feature or request labels Jun 7, 2021
@svenoe
Copy link
Contributor

svenoe commented Jun 7, 2021

A package which allows making those fields optional, and or hiding them without any ACL interactions already exists. Integrating ACLs for standard fields are an additional step which will have to be looked into.

I will think about how to make the package available.

@svenoe
Copy link
Contributor

svenoe commented Jun 7, 2021

Hm...a mention in a discussion is not noted in the issue apparently - I have a question concerning article creation which I wrote in: #1020 (comment)

@OlliW
Copy link
Author

OlliW commented Jul 7, 2021

Ok, do you have any progress on this point?

svenoe added a commit that referenced this issue Nov 23, 2021
…e article creation. Alongside this the class ooo.ACLHidden is now oooACLHidden and is used to hide objects via css.
svenoe added a commit that referenced this issue Nov 23, 2021
svenoe added a commit that referenced this issue Nov 23, 2021
@svenoe
Copy link
Contributor

svenoe commented Nov 23, 2021

I merged this into rel-10_1. We had some internal discussion on how to handle things, finally we decided to treat Subject, Body and Attachment together as "Article", this is where we are at. I kept the differentiation bewtween the three at some places however, to make it easier for packages to drop in here (actually maybe I should have also done that more in Core.AJAX.js).

In general we will (re)enable all other fields like Queue/Type/... because while some of them (the Queue e.g.) can be solved via Autoselect, this is not possible for all fields like SLA, or others. which are not mandatory for a ticket itself. Including them needs a little more work, though, as they have to be included in the convergence loops, as hiding them will delete their values.

@svenoe svenoe added this to the OTOBO 10.1.1 milestone Nov 23, 2021
@svenoe
Copy link
Contributor

svenoe commented Nov 23, 2021

The above should probably be done in another issue, as it will probably not come directly with 10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Contribution from other parties - thank you! :) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants