Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: upgrade to Perl 5.34.0 #1081

Closed
bschmalhofer opened this issue Jun 12, 2021 · 4 comments
Closed

Docker: upgrade to Perl 5.34.0 #1081

bschmalhofer opened this issue Jun 12, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bschmalhofer
Copy link
Contributor

Currently the web Docker image is based on Perl 5.32.0. Let's upgrade to the new release 5.34.0, https://hub.docker.com/_/perl. The changelog https://perldoc.perl.org/5.34.0/perldelta shows nothing scary. Most interesting is the new experimental try/catch syntax. In older Perls this syntax is useable via https://metacpan.org/pod/Feature::Compat::Try.

The minimal supported version of Perl will stay at 5.24.

@bschmalhofer bschmalhofer added the enhancement New feature or request label Jun 12, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jun 12, 2021
@bschmalhofer bschmalhofer self-assigned this Jun 12, 2021
@svenoe
Copy link
Contributor

svenoe commented Jun 12, 2021

What would be the reason? We have to stay compatible with non-docker installations, so new features will not be usable anyways.

@bschmalhofer
Copy link
Contributor Author

OTOBO specifies Perl 5.24 as minimum Perl version, there is no max version specified. This means that Perl 5.34 is officially supported. A good way to guarantee that support is to use 5.34 in Docker based installation.

@bschmalhofer
Copy link
Contributor Author

First test run looks mostly fine. There a 9 failing scripts. Most, if not all, of these failures are due to an encoding issue in Kernel::System::Log::Log(). See #1082.

@bschmalhofer
Copy link
Contributor Author

Running the test suite with Perl 5.34.0 in the Docker images showed the same failures as in HEAD of rel-10_1. Looks good. PR is merged. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants