Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Put the docker specific settings in a XML file #123

Closed
bschmalhofer opened this issue Jul 1, 2020 · 2 comments
Closed

Docker: Put the docker specific settings in a XML file #123

bschmalhofer opened this issue Jul 1, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request wontfix This will not be worked on
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jul 1, 2020 •
edited
Loading

Right now the docker specific settings are set in Kernel/Config.pm. This means that they can't be changed by SysConfig.
A better approach is to move the settings into an .xml file in Kernel/Config/Files/XML.

The sub Kernel::System::SysConfig::ConfigurationXML2DB() declares an order of the config files based on the attribute otobo.ìnitin the XML file:

  1. Framework
  2. Application
  3. Config
  4. Changes

So adding an override file with otobo_config.init = 'Config' should do the trick.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Jul 2, 2020
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.0 Jul 2, 2020
@bschmalhofer
Copy link
Contributor Author

The branch for this feature was misnamed as issue-113-Config_pm instead of issue-123-Config_pm

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.0, OTOBO 10.1 Jul 7, 2020
bschmalhofer added a commit that referenced this issue Jul 10, 2020
@bschmalhofer
Issue #123: At least remove Elasticsearch::Active from Config.pm
770af20 
This setting will be activated in the installer, when ES is available.
bschmalhofer added a commit that referenced this issue Jul 10, 2020
@bschmalhofer
Issue #123: Enhance a code comment
b182f3f
@bschmalhofer bschmalhofer mentioned this issue Jul 14, 2020
Merged
bschmalhofer added a commit that referenced this issue Jul 17, 2020
@bschmalhofer
Issue #123: fix stupid syntax error concerning scope of $FH.
615cd97 
And use the autoclose of lexical file handles.
bschmalhofer added a commit that referenced this issue Jul 17, 2020
@bschmalhofer
Merge pull request #212 from RotherOSS/issue-123-fix_syntax
51cba83 
Issue #123: fix stupid syntax error concerning scope of $FH.
bschmalhofer added a commit that referenced this issue Jul 17, 2020
@bschmalhofer
Issue #123: fix stupid syntax error concerning scope of $FH.
4726b4b 
And use the autoclose of lexical file handles.
@bschmalhofer bschmalhofer added the wontfix This will not be worked on label Dec 28, 2020
@bschmalhofer
Copy link
Contributor Author

Not really sure what the intention was. Closing the issue as it doesn't seem to be important.

@bschmalhofer bschmalhofer self-assigned this Jan 19, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer