-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use caching in the github actions #1255
Comments
Mostly for checking whether ./github/workflows/code_policy.yml catches the errors
But still not tidy. Should be reported by code_policy.yml
Install fewer Debian packages, improve caching.
Did not bother to investige the configuration problems of XML::XSLT
Specifically, Perl::Critic was missing.
Issue #1255: add an usage message
It is not clear whether this works as expected. There are several cases to be checked:
|
No longer use hashfile() as that gives a different SHA.
Issue #1255: use the REST interface for SHA
Mainly for testing the github actions.
Another optimisation in cache_local_lib.yml. For getting a checksum on cpanfile.docker, we don't need a complete checkout of the branch. We can ask Github directly via the REST interface. Unfortunately the SHA from the webservice is not the same value as returned by Still not closing, in case problems crop up. |
Issue #1255: merge syntax_check.yml into code_policy.yml
Looks good. Only the code_policy.yml workflow is now executed. This workflow contains the syntax check. |
This seems to work without hassle. Let's use it for rel-10_0 as well. |
Another idea for a speedup. Install Code::TidyAll and dependencies via cpanm. This should make the installation of Debian packages faster. |
Closing this issue. Any problems that pop up should be fixed in #1278. |
Here is another idea. When looking at https://github.com/RotherOSS/otobo/runs/3684898399?check_suite_focus=true we see that there is one step that takes most of the time. That's installing the CPAN dependencies from cpanfile.docker. This could be eliminated by using a dedicated Docker image with all the dependencies installed. A better idea might be to simply cache the CPAN dependencies. Either the directory with the installed Perl modules, or the .cpanm workdir.
Originally posted by @bschmalhofer in https://github.com/RotherOSS/CodePolicy/issues/51#issuecomment-925749171
The text was updated successfully, but these errors were encountered: