Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminiate $DIBI$ in Kernel/Config.pm.dist #1271

Closed
bschmalhofer opened this issue Sep 27, 2021 · 2 comments
Closed

Eliminiate $DIBI$ in Kernel/Config.pm.dist #1271

bschmalhofer opened this issue Sep 27, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

Currently the files Kernel/Config.pm.dist and Kernel/Config-pm.docker.dist_ have a section like:

    # ---------------------------------------------------- #
    # data inserted by installer                           #
    # ---------------------------------------------------- #
    # $DIBI$

This is confusing as Kernel/Module/Installer.pm apparently does not mess with that macro. I propose to remove this section.
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Sep 27, 2021
@bschmalhofer
Copy link
Contributor Author

See also #1210.

@bschmalhofer bschmalhofer self-assigned this Nov 4, 2021
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Nov 4, 2021
bschmalhofer added a commit that referenced this issue Nov 4, 2021
@bschmalhofer
Issue #1271: remove the $DIBI$ placeholder
d9b18bf 
That placeholder was apparently used by an OTRS installer,
which does not exist for OTOBO.
bschmalhofer added a commit that referenced this issue Nov 4, 2021
@bschmalhofer
Merge pull request #1382 from RotherOSS/issue-#1271-DIBI
bfc311d 
Issue #1271: remove the $DIBI$ placeholder
@bschmalhofer
Copy link
Contributor Author

Placeholder is removed. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer