Strange check for unique file names in article storage

[bschmalhofer]

Here is some code from Kernel/System/Ticket/Article/Backend/MIMEBase/ArticleStorageFS.pm .

for ( my $i = 1; $i <= 50; $i++ ) {
    if ( exists $UsedFile{ Unicode::Normalize::NFC($NewFileName) } ) {
        if ( $Param{Filename} =~ /^(.*)\.(.+?)$/ ) {
            $NewFileName = "$1-$i.$2";
        }
        else {
            $NewFileName = "$Param{Filename}-$i";
        }
    }
}

Looks like a last is missing there. Maybe this was never noticed because attachments are sorted alphabetically.

[bschmalhofer]

Did some tidying of the three article storage backends. The goal being that the code becomes more similar accross the modules.
The logic for creating the unique file names is left in place. There might be a good reason for why the checks are done this way. At least there are no bug reports about the current approach.

Closing only after the next run of the test suite.

[bschmalhofer]

The latest run of the test suite looked fine. Closing this issue.