Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daemon: no longer check for changed file Kernel/Config/ZZZAuto.pm #1332

Closed
2 tasks done
bschmalhofer opened this issue Oct 19, 2021 · 1 comment
Closed
2 tasks done

Daemon: no longer check for changed file Kernel/Config/ZZZAuto.pm #1332

bschmalhofer opened this issue Oct 19, 2021 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Oct 19, 2021 •
edited
Loading

The file ZZZAuto.pm has not been used since the release of OTRS 6. Thus there is no need for the daemon to check for changes in that files. The only relevant files in Kernel/Config/Files are:

  • ZZZAAuto.pm
  • ZZZACL.pm
  • ZZZProcessManagemenz.pm

TODO:

  • remove Linux::Inotify2 watch on_ ZZZAuto,pm_
  • document why the file watcher make some kind of sense
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Oct 19, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.1 milestone Oct 19, 2021
@bschmalhofer bschmalhofer self-assigned this Oct 19, 2021
bschmalhofer added a commit that referenced this issue Oct 22, 2021
@bschmalhofer
Issue #1332: add code comment
5bcabdc 
stating the watching for config changes might be useless
bschmalhofer added a commit that referenced this issue Oct 22, 2021
@bschmalhofer
Issue #1332: ZZZAuto.pm is no longer relevant
9e64952 
was removed for OTRS 6
bschmalhofer added a commit that referenced this issue Oct 22, 2021
@bschmalhofer
Merge pull request #1352 from RotherOSS/issue-#1332-ZZZAuto_pm
36ca94a 
Issue #1332 zzz auto pm
@bschmalhofer
Copy link
Contributor Author

No longer check for ZZZAuto.pm. Add note that the whole check might be useless anyways. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer