-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are the special cases for Net::DNS still useful ? #1370
Milestone
Comments
Someone can have a look at this. |
The workaround was added in 2014, see znuny/Znuny@1ce2561 . OTOBO currently requires Perl 5.24 which was released in May 2016. So let's assume that this is no longer an issue in newer versionsions of Net::DNS. Let's required Net::DNS 1.05 which was released in March 2016. |
bschmalhofer
added a commit
that referenced
this issue
Jul 25, 2023
from check whether the module can be loaded. Require Net::DNS 1.05 or later as that can be assumed to be installed in Perl 5.24 installations.
bschmalhofer
added a commit
that referenced
this issue
Jul 25, 2023
Issue #1370: Don't excempt Net::DNS and Email::Valid
Special handling of Net::DNS is gone. Closing this issue. |
bschmalhofer
added a commit
that referenced
this issue
Jul 25, 2023
bschmalhofer
added a commit
that referenced
this issue
Jul 25, 2023
bschmalhofer
added a commit
that referenced
this issue
Jul 25, 2023
bschmalhofer
added a commit
that referenced
this issue
Jul 25, 2023
Issue #1370: Mark Cpanel::JSON::XS as required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the code there are several cases with special handling for Net::DNS. E.g. in bin/otobo.CheckModules.pl:
Is this still necessary? I recall that tests can take a long time, but actual loading seems to be fast.
The text was updated successfully, but these errors were encountered: