Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are the special cases for Net::DNS still useful ? #1370

Closed
bschmalhofer opened this issue Oct 29, 2021 · 3 comments
Closed

Are the special cases for Net::DNS still useful ? #1370

bschmalhofer opened this issue Oct 29, 2021 · 3 comments
Assignees
Labels
question Further information is requested tidying Tidying of the code
Milestone

Comments

@bschmalhofer
Copy link
Contributor

In the code there are several cases with special handling for Net::DNS. E.g. in bin/otobo.CheckModules.pl:

    # Test if all module dependencies are installed by requiring the module.
    #   Don't do this for Net::DNS as it seems to take very long (>20s) in a
    #   mod_perl environment sometimes.
    my %DontRequire = (
        'Net::DNS'     => 1,
        'Email::Valid' => 1,    # uses Net::DNS internally
    );

Is this still necessary? I recall that tests can take a long time, but actual loading seems to be fast.

bes:~/devel/OTOBO/otobo (issue-#27-remove_RPC_pm)$ time perl -MNet::DNS -E 'say $INC{"Net/DNS.pm"}'
/usr/share/perl5/Net/DNS.pm

real 0m0,075s
user 0m0,071s
sys 0m0,004s

@bschmalhofer bschmalhofer added the question Further information is requested label Oct 29, 2021
@bschmalhofer bschmalhofer added this to the Wishlist milestone Oct 29, 2021
@svenoe svenoe modified the milestones: Wishlist, OTOBO 11.0 Feb 10, 2023
@svenoe
Copy link
Contributor

svenoe commented Feb 10, 2023

Someone can have a look at this.

@svenoe svenoe reopened this Feb 10, 2023
@bschmalhofer bschmalhofer self-assigned this Jul 24, 2023
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jul 24, 2023
@bschmalhofer
Copy link
Contributor Author

The workaround was added in 2014, see znuny/Znuny@1ce2561 . OTOBO currently requires Perl 5.24 which was released in May 2016. So let's assume that this is no longer an issue in newer versionsions of Net::DNS. Let's required Net::DNS 1.05 which was released in March 2016.

bschmalhofer added a commit that referenced this issue Jul 25, 2023
from check whether the module can be loaded.
Require Net::DNS 1.05 or later as that can be assumed to be
installed in Perl 5.24 installations.
bschmalhofer added a commit that referenced this issue Jul 25, 2023
Issue #1370: Don't excempt Net::DNS and Email::Valid
@bschmalhofer
Copy link
Contributor Author

Special handling of Net::DNS is gone. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested tidying Tidying of the code
Projects
None yet
Development

No branches or pull requests

2 participants