Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the interface modules into real Plack apps. #1436

Closed
bschmalhofer opened this issue Nov 22, 2021 · 3 comments
Closed

Turn the interface modules into real Plack apps. #1436

bschmalhofer opened this issue Nov 22, 2021 · 3 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

A hopefully final beautification. The interface modules can inherit from Plack::Component, https://metacpan.org/pod/Plack::Component, and Response() can be renamed to call(). This would leave us with:

mount "/public.pl" => Kernel::System::Web::InterfacePublic->new()->to_app;
in otobo.psgi.

Originally posted by @bschmalhofer in #1431 (comment)
@bschmalhofer
Copy link
Contributor Author

Do that only after checking whether there is a reason that the interface modules are managed by the object manager.

@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Nov 22, 2021
@bschmalhofer bschmalhofer added the enhancement New feature or request label Nov 22, 2021
@bschmalhofer bschmalhofer changed the title Turn the interface modules into real plack apps. Turn the interface modules into real Plack apps. Nov 22, 2021
bschmalhofer added a commit that referenced this issue Nov 23, 2021
@bschmalhofer
Issue #1436: add the wrapper module Kernel::System::Web::App
1a27110 
that loads and calls the interface modules.
Just to have nicer syntax in otobo.psgi.
bschmalhofer added a commit that referenced this issue Nov 23, 2021
@bschmalhofer
Merge pull request #1440 from RotherOSS/issue-#1436-web_app_take_2
52ea606 
Issue #1436: add the wrapper module Kernel::System::Web::App
@bschmalhofer
Copy link
Contributor Author

It turned out that using a wrapper module was the easier route. This approach guarantees that there is no persistent data between requests.
Closing this issue only after the next run of the test suite.

@bschmalhofer
Copy link
Contributor Author

Looks like this does work. Closing this issue.

@bschmalhofer bschmalhofer self-assigned this Nov 25, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer