Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password sanity check in installer.pl #146

Closed
bschmalhofer opened this issue Jul 7, 2020 · 2 comments
Closed

Password sanity check in installer.pl #146

bschmalhofer opened this issue Jul 7, 2020 · 2 comments
Assignees
@svenoe
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

In installer.pl there is a JavaScript check that the repeated DB password for 'otobo' is the same as the password,

  1. Password is entered
  2. Start typing the repeated password => Password is marked in red
  3. Really typing the identical password => Password is still marked in red
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Jul 7, 2020
@bschmalhofer
Copy link
Contributor Author

Also: maybe only activate the 'Continue' button when the passwords match

@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Jul 14, 2020
svenoe pushed a commit that referenced this issue Aug 18, 2020
Issue #146: Switched the password check for DBUser in Installer.pl to…
2e5e2ed 
… the password repeat field. Added for mssql and postgresql. Moved generated password info to password field.
@svenoe
Copy link
Contributor

svenoe commented Aug 18, 2020

Password check moved to the "repeat"-field. The validate plugin does not instantly run, but this is the same at other locations. In any case, no false negatives anymore, if filled in the correct order.

The unclickable continue button is not so important, imo.

@svenoe svenoe closed this as completed Aug 18, 2020
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svenoe svenoe

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
2 participants
@bschmalhofer @svenoe