Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect dates in detail view of AdminPerformanceLog #1499

Closed
bschmalhofer opened this issue Dec 11, 2021 · 2 comments
Closed

Incorrect dates in detail view of AdminPerformanceLog #1499

bschmalhofer opened this issue Dec 11, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.14

Comments

@bschmalhofer
Copy link
Contributor

While looking into this I noticed that the detailed view of the performance log is off.

Bildschirmfoto vom 2021-12-11 14-00-07

This is from a fresh installation that is only some minutes old. The data seems to be correctly aggregated by 1 minute but the date in the very left column varies by hour. Looks like a factor of 60 was incorrectly applied somewhere along the line.

Originally posted by @bschmalhofer in #1481 (comment)
@bschmalhofer bschmalhofer self-assigned this Dec 11, 2021
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Dec 11, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.14 milestone Dec 11, 2021
@bschmalhofer
Copy link
Contributor Author

Looks like this bug was introduced in 2017 by OTRS/otrs@6da5466.

bschmalhofer added a commit that referenced this issue Dec 11, 2021
@bschmalhofer
Issue #1499: subtract minutes instead of hours
d5c0b54 
because the time slots that are aggregated over are given in minutes
bschmalhofer added a commit that referenced this issue Dec 11, 2021
@bschmalhofer
Issue #1499: add standard pragmas
996a14f 
in this case 'use v5.24' and 'use utf8'
bschmalhofer added a commit that referenced this issue Dec 11, 2021
@bschmalhofer
Issue #1499: tidying
cd5fb0b 
Enhanced code comments, added empty lines for better code structuring
bschmalhofer added a commit that referenced this issue Dec 11, 2021
@bschmalhofer
Issue #1499: tidying
7464c72 
Arrays and hashes are already intialised when they are declared.
Use "join ''" instead of concatenation, because it looks neater.
bschmalhofer added a commit that referenced this issue Dec 11, 2021
@bschmalhofer
Merge pull request #1501 from RotherOSS/issue-#1499-incorrect_timestamps
e8f5e70 
Issue #1499 incorrect timestamps
@bschmalhofer
Copy link
Contributor Author

Removed a factor of 60 when subtracting minutes from the current time. The detail view looks now sane. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.14
Development

No branches or pull requests
1 participant
@bschmalhofer