Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration: incorrect version check for the OTOBO release #1510

Closed
bschmalhofer opened this issue Dec 16, 2021 · 2 comments
Closed

Migration: incorrect version check for the OTOBO release #1510

bschmalhofer opened this issue Dec 16, 2021 · 2 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.15

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Dec 16, 2021 •
edited
Loading

There is a bug in line 212 of Kernel/System/MigrateFromOTRS/OTOBOFrameworkVersionCheck.pm. The check is for OTOBO 10.1 while it should check for 10.0. The culprit was the commit a07956d .

This bug was reported in the OTOBO Forum:
https://otobo.de/en/forums/topic/fehler-bei-der-vorpruefungen-zur-migration/

Originally posted by @bschmalhofer in #1317 (comment)
@bschmalhofer bschmalhofer self-assigned this Dec 16, 2021
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Dec 16, 2021
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.15 milestone Dec 16, 2021
bschmalhofer added a commit that referenced this issue Dec 16, 2021
@bschmalhofer
Issue #1510: enhance or fix code comments
3945033
bschmalhofer added a commit that referenced this issue Dec 16, 2021
@bschmalhofer
Issue #1510: Check for OTOBO version 10.0, not 10.1
2db1722
bschmalhofer added a commit that referenced this issue Dec 16, 2021
@bschmalhofer
Merge pull request #1511 from RotherOSS/issue-#1510-otobo_version_check
b6845c9 
Issue #1510 otobo version check
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Dec 16, 2021 •
edited
Loading

TODO:

  • Testmigration with OTOBO 10.0.x as target
  • Testmigration with OTOBO 10.1.x as target

@bschmalhofer bschmalhofer changed the title Migration: incorrect version check for the OTOBO relaease Migration: incorrect version check for the OTOBO release Dec 16, 2021
@bschmalhofer
Copy link
Contributor Author

Tested the migration with OTOBO 10.1.x under Apache as the target. The version check is fine. So the issue can be closed.

But there is another error right after the OTOBO version check. Opening a new issue for that,
Bildschirmfoto vom 2021-12-16 16-21-01

@bschmalhofer bschmalhofer mentioned this issue Dec 16, 2021
Closed
bschmalhofer added a commit that referenced this issue Dec 16, 2021
@bschmalhofer
Issue #1510: Check for OTOBO 10.1, not OTOBO 10.0
6d188ab 
The check was reverted to 10.0 by merging changes from 10.0.
bschmalhofer added a commit that referenced this issue Dec 16, 2021
@bschmalhofer
Issue #1510: Oh well, a backslash fell to the wayside
b865e3d
bschmalhofer added a commit that referenced this issue Dec 16, 2021
@bschmalhofer
Issue #1510: remove an useless capture in the version check
30dac4e
bschmalhofer added a commit that referenced this issue Dec 16, 2021
@bschmalhofer
Merge pull request #1513 from RotherOSS/issue-#1510-otobo_version_che…
69f47db 
…ck_10_1

Issue #1510 otobo version check 10 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.15
Development

No branches or pull requests
1 participant
@bschmalhofer