Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitTests: 127.0.0.1 vs. 'none' #161

Closed
bschmalhofer opened this issue Jul 8, 2020 · 1 comment
Closed

UnitTests: 127.0.0.1 vs. 'none' #161

bschmalhofer opened this issue Jul 8, 2020 · 1 comment
Milestone
OTOBO 10.0.1

Comments

@bschmalhofer
Copy link
Contributor

Some Unittests fail because they expect 'none' and get 127.0.0.1. The consensus is that this is fine and that the test cases should be adapted.
bschmalhofer added a commit that referenced this issue Jul 9, 2020
@bschmalhofer
Issue #161: returning 127.0.0.1 for the local addr is fine
7b06eab
bschmalhofer added a commit that referenced this issue Jul 9, 2020
@bschmalhofer
Merge pull request #173 from RotherOSS/issue-161-UserRemoteAddr
9039a89 
Issue #161: returning 127.0.0.1 for the local addr is fine
@bschmalhofer
Copy link
Contributor Author

Looks good now. Closing.

@bschmalhofer bschmalhofer added this to the OTOBO 10.0 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OTOBO 10.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer