Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce setting in Config.pm #1672

Closed
1 task done
bschmalhofer opened this issue Mar 15, 2022 · 3 comments
Closed
1 task done

Reduce setting in Config.pm #1672

bschmalhofer opened this issue Mar 15, 2022 · 3 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.7

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Mar 15, 2022 •
edited
Loading

The file Kernel/Config,pm serves a specifc use case.

  1. Hold settings that are set during installations.
  2. Hold changed settings that override values that are set Kernel/Config/Defaults.pm
  3. Hold settings that only a sysadmin should be able to change

TODO:

  • move settings that are not covered by 1. and 2. from Config.pm to Defaults.pm
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Mar 15, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Mar 15, 2022
@bschmalhofer bschmalhofer self-assigned this Mar 15, 2022
@svenoe svenoe modified the milestones: OTOBO 11.0, OTOBO 10.1.3 Apr 7, 2022
@svenoe svenoe modified the milestones: OTOBO 10.1.5, OTOBO 10.1.6 Jun 15, 2022
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Feb 11, 2023 •
edited
Loading

A review of this issue by @svenoe and @bschmalhofer came to this result:

  • the file Config.pm.dist is fine
  • the S3 specific settings should move to Kernel/Config/Defaults.pm, inactive per default
  • the other Docker specific settings should move to Kernel/Config/Defaults.pm, active in the Docker case
  • further improvements and simplifications will handled in separate issues

bschmalhofer added a commit that referenced this issue Feb 11, 2023
@bschmalhofer
Issue #1672: Document the changed DatabasePw
034dc16 
Under Docker a different default database password is used.
bschmalhofer added a commit that referenced this issue Feb 11, 2023
@bschmalhofer
Issue #1672: tidying
56f9909 
use v5.24   is now the first pragma
remove empty comment lines
bschmalhofer added a commit that referenced this issue Feb 11, 2023
@bschmalhofer
Issue #1672: minimize the differences
bca4c0b 
between Config.pm.docker.dist and Config.pm.dist
@bschmalhofer
Copy link
Contributor Author

Discussed this with @svenoe again and we reached the conclusion:

  • Leave the Docker related settings in Kernel/Config.pm.docker.dist
  • Put the S3 related settings commented out into Kernel/Config/Defaults.pm

bschmalhofer added a commit that referenced this issue Feb 20, 2023
@bschmalhofer
Issue #1672: enhance documentation for Docker specifics
e35a33b 
Start mentioning DatabasePw
bschmalhofer added a commit that referenced this issue Feb 20, 2023
@bschmalhofer
Issue #1672: move sample S3 settings to Defaults.pm
975a2f7
bschmalhofer added a commit that referenced this issue Feb 20, 2023
@bschmalhofer
Merge pull request #2184 from RotherOSS/issue-#1672-only_S3_settings_…
3577820 
…move

Issue #1672 only s3 settings move
@bschmalhofer
Copy link
Contributor Author

At least the S3 specific settings have gone from Kernel/Config.pm. Closing this issues for lack of good ideas for more simplifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.7
Development

No branches or pull requests
2 participants
@bschmalhofer @svenoe