Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache Config: remove obsolete option DocumentRoot #1715

Closed
bschmalhofer opened this issue Apr 11, 2022 · 3 comments
Closed

Apache Config: remove obsolete option DocumentRoot #1715

bschmalhofer opened this issue Apr 11, 2022 · 3 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.3

Comments

@bschmalhofer
Copy link
Contributor

In most sample configurations the location '/' is declared. This means that DocumentRoot is never used and thus can be removed.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Apr 11, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.3 milestone Apr 11, 2022
@bschmalhofer bschmalhofer self-assigned this Apr 11, 2022
bschmalhofer added a commit that referenced this issue Apr 22, 2022
@bschmalhofer
Issue #1715: update a code comment
55df09d 
SSL is already handled in the config file
bschmalhofer added a commit that referenced this issue Apr 22, 2022
@bschmalhofer
Issue #1715: remove redundant setting for DocumentRoot
6b52a3a
bschmalhofer added a commit that referenced this issue Apr 22, 2022
@bschmalhofer
Issue #1715:
e61754d
@bschmalhofer
Copy link
Contributor Author

Pondered this some more and found no good reason for keeping the DocumentRoot setting. Thus removed it.

bschmalhofer added a commit that referenced this issue Apr 22, 2022
@bschmalhofer
Merge pull request #1730 from RotherOSS/issue-#1715-document_root
c1b6307 
Issue #1715 document root
bschmalhofer added a commit that referenced this issue Apr 22, 2022
@bschmalhofer
Issue #1715: meaningful error when mod_perl is not loaded
c48edae
bschmalhofer added a commit that referenced this issue Apr 22, 2022
@bschmalhofer
Merge pull request #1731 from RotherOSS/issue-#1715-document_root
68dbbdc 
Issue #1715: meaningful error when mod_perl is not loaded
@bschmalhofer
Copy link
Contributor Author

Another thing, the setting MaxRequestsPerChild is now called MaxConnectionsPerlChild. See https://httpd.apache.org/docs/trunk/de/mod/mpm_common.html#maxconnectionsperchild.

@bschmalhofer bschmalhofer mentioned this issue Apr 22, 2022
Closed
@bschmalhofer
Copy link
Contributor Author

Inadvertently checked in the error message when mod_perl is not active. The check is IMHO sensible, let's leave it in the code.

PR is merged, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.3
Development

No branches or pull requests
1 participant
@bschmalhofer