Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sector Nord AG: Replaced hardcoded attributes with a dynamic Sysconfig in Kernel/System/Ticket/Event/NotificationEvent.pm #1717

Closed
bschmalhofer opened this issue Apr 12, 2022 · 1 comment
Closed

Sector Nord AG: Replaced hardcoded attributes with a dynamic Sysconfig in Kernel/System/Ticket/Event/NotificationEvent.pm #1717

bschmalhofer opened this issue Apr 12, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
OTOBO 10.0.16

Comments

@bschmalhofer
Copy link
Contributor

The changes that were applied in Znuny in znuny/Znuny#171 look sensible to me. I propose to apply them to OTOBO as well.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Apr 12, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.16 milestone Apr 12, 2022
bschmalhofer added a commit that referenced this issue Apr 21, 2022
@bschmalhofer
Issue #1717: merge in changes made in Znuny
9810c17 
with some slight modifications:
- use postfix dereferencing
- introduce a new scope to reduce visiblilty of some variables
- use a theoretically faster hash merge syntax
bschmalhofer added a commit that referenced this issue Apr 21, 2022
@bschmalhofer
Merge pull request #1727 from RotherOSS/issue-#1717-notification_event
d780eb0 
Issue #1717: merge in changes made in Znuny
@bschmalhofer
Copy link
Contributor Author

Testsuite still looks good. PR is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.0.16
Development

No branches or pull requests
1 participant
@bschmalhofer