Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTests: 16 failures scripts/test/Compile.t #174

Closed
bschmalhofer opened this issue Jul 9, 2020 · 5 comments
Closed

UnitTests: 16 failures scripts/test/Compile.t #174

bschmalhofer opened this issue Jul 9, 2020 · 5 comments
Assignees
Milestone

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jul 9, 2020

Currently there are 17 compile failures. Some of these failures are for optional or Windows specific modules.
Also looks like Selenium has problems.
Also some 'use DateTime 1.08' problems.

Investigate.

@bschmalhofer
Copy link
Contributor Author

Nothing has changed.

@bschmalhofer bschmalhofer changed the title UnitTests: investigate failures of scripts/Test/Compile.t UnitTests: 17 failures scripts/Test/Compile.t Jul 10, 2020
@bschmalhofer bschmalhofer changed the title UnitTests: 17 failures scripts/Test/Compile.t UnitTests: 16 failures scripts/Test/Compile.t Jul 13, 2020
@bschmalhofer
Copy link
Contributor Author

The failures are down to 16, as CGI::Fast has been removed.

@bschmalhofer
Copy link
Contributor Author

Failures down to 12 after fixing Kernel::System::SysConfig.

@bschmalhofer bschmalhofer changed the title UnitTests: 16 failures scripts/Test/Compile.t UnitTests: 16 failures scripts/test/Compile.t Jul 17, 2020
bschmalhofer added a commit that referenced this issue Jul 17, 2020
One never knows what $FindBin::Bin actually is.
bschmalhofer added a commit that referenced this issue Jul 17, 2020
Rewrite using Test::Compile::Internal and Test2::V0.
Mark the expected failures as TODO.
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Jul 17, 2020

Some tests are expected to fail, e.g. when they provide support for Windows or when dependencies are optional.
The failure of SOAP::Lite appears to be a known bug which should be no hindrance for OTOBO.
For the failure of Kernel/System/SysConfig/Migration.pm there is now #213 .

my %PmFileFails = (
    'Kernel/System/Auth/Radius.pm'               => 'Authen::Radius is not required',
    'Kernel/System/CustomerAuth/Radius.pm'       => 'Authen::Radius is not required',
    'Kernel/System/SysConfig/Migration.pm'       => 'scripts/MigrateFromOTRS/Base.pm does not exist',
    'Kernel/cpan-lib/Devel/REPL/Plugin/OTOBO.pm' => 'Devel::REPL::Plugin is not required',
    'Kernel/cpan-lib/Font/TTF/Win32.pm'          => 'Win32 is not supported',
    'Kernel/cpan-lib/LWP/Authen/Ntlm.pm'         => 'Authen::NLTM is not required',
    'Kernel/cpan-lib/LWP/Protocol/GHTTP.pm'      => 'HTTP::GHTTP is not required',
    'Kernel/cpan-lib/PDF/API2/Win32.pm'          => 'Win32 is not supported',
    'Kernel/cpan-lib/SOAP/Lite.pm'               => 'some strangeness concerning SOAP::Constants',
    'Kernel/cpan-lib/URI/urn/isbn.pm'            => 'Business::ISBN is not required',
);

bschmalhofer added a commit that referenced this issue Jul 20, 2020
Move slowly in order to reduce risk.
bschmalhofer added a commit that referenced this issue Jul 20, 2020
Issue #174: revert to setting @inc in Kernel/Config/Defaults.pm
@bschmalhofer
Copy link
Contributor Author

Closing as the failures are either acceptable or have their own issues already opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant