Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an useless 'do #1764

Closed
bschmalhofer opened this issue May 7, 2022 · 1 comment
Closed

Remove an useless 'do #1764

bschmalhofer opened this issue May 7, 2022 · 1 comment
Assignees
Labels
tidying Tidying of the code
Milestone

Comments

@bschmalhofer
Copy link
Contributor

The do $TargetFile in Kernel::System::SysConfig::ConfigurationDeploySync() seem pretty useless, https://github.com/RotherOSS/otobo/blob/rel-10_1/Kernel/System/SysConfig.pm#L3752 . Simply do-ing the ZZZAAuto.pm file should have no effect at all.

Also, the use of the preceeding require is not obvious. The ZZZAAuto.pm is required again in Kernel::Config::Defaults__new() called by
my $CurrentDeploymentID = $Kernel::OM->Get('Kernel::Config')->Get('CurrentDeploymentID') || 0;

I propose to remove the whole section.

@svenoe : What do you think?

@bschmalhofer bschmalhofer added the tidying Tidying of the code label May 7, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 10.1.5 milestone May 7, 2022
@bschmalhofer bschmalhofer self-assigned this May 7, 2022
bschmalhofer added a commit that referenced this issue May 12, 2022
also some tidying and enhanced code comments
bschmalhofer added a commit that referenced this issue May 12, 2022
Issue #1764: avoid an not needed 'do' of ZZZAAuto.pm
@bschmalhofer
Copy link
Contributor Author

Test suite, with OTOBO_SYNC_WITH_S3, looks mostly fine. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidying Tidying of the code
Projects
None yet
Development

No branches or pull requests

1 participant