Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow creation of DateTime objects from CPAN DateTime objects #1993

Closed
bschmalhofer opened this issue Oct 23, 2022 · 5 comments
Closed

Allow creation of DateTime objects from CPAN DateTime objects #1993

bschmalhofer opened this issue Oct 23, 2022 · 5 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 11.0.1

Comments

@bschmalhofer
Copy link
Contributor

In OTOBO 10.1 there is a kind of secret possibility to create instances of Kernel::System::DateTimeby passing a DateTimeobject via the parameter _CPANDateTimeObject. This approach should be made official for OTOBO 11.0.
@bschmalhofer bschmalhofer added the enhancement New feature or request label Oct 23, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Oct 23, 2022
@bschmalhofer bschmalhofer self-assigned this Oct 23, 2022
@svenoe svenoe removed the enhancement New feature or request label Feb 10, 2023
@svenoe
Copy link
Contributor

svenoe commented Feb 10, 2023

Is permitted.

@svenoe svenoe closed this as completed Feb 10, 2023
@svenoe
Copy link
Contributor

svenoe commented Feb 10, 2023

Please add a comment that it is allowed for K::S::DT

@svenoe svenoe reopened this Feb 10, 2023
bschmalhofer added a commit that referenced this issue Mar 3, 2023
@bschmalhofer
Issue #1993: convert to Test2::V0
26a3ac7
bschmalhofer added a commit that referenced this issue Mar 3, 2023
@bschmalhofer
Issue #1993: officially support CPANDateTimeObject
6dde5d2 
as a constructor parameter to Kernel::System::DateTime.
bschmalhofer added a commit that referenced this issue Mar 3, 2023
@bschmalhofer
Merge pull request #2207 from RotherOSS/issue-#1993-cpandatetimeobject
b275407 
Issue #1993 cpandatetimeobject
@bschmalhofer
Copy link
Contributor Author

Renamed the secret parameter _CPANDateTimeObject to CPANDateTimeObject, updated the POD and added a test. Closing this issue.

@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Mar 4, 2023 •
edited
Loading

Reopening. Currently the passed in CPANDateTime is simple stored as the internal object. But this allows action at a distance, which is usually not expected.

TODO:

  • add a test that there is no action at a distance
  • fix the failing test

@bschmalhofer bschmalhofer reopened this Mar 4, 2023
bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Issue #1993: start using subtests and isa_ok().
d09612e 
This is only for tidying.
bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Issue #1993: check for action at a distance
a46cad4 
Changing the source object should not affect the target object.
bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Issue #1993: clone the passed in CPANDateTime object
1f0cfa1 
For avoiding potetial action at a distance.
bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Issue #1993: eliminate an unneeded clone
475eb40
bschmalhofer added a commit that referenced this issue Mar 4, 2023
@bschmalhofer
Merge pull request #2208 from RotherOSS/issue-#1993-action_at_a_distance
0850a85 
Issue #1993 action at a distance
@bschmalhofer
Copy link
Contributor Author

Cloned the passed in CPANDateTime object and did some cleanup. Tests look fine. Closing this issue again.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.1 May 21, 2024
@bschmalhofer bschmalhofer added the enhancement New feature or request label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
2 participants
@bschmalhofer @svenoe