Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workaround for ancient bug in Lotus Notes #2026

Closed
2 tasks done
bschmalhofer opened this issue Dec 1, 2022 · 2 comments
Closed
2 tasks done

Remove workaround for ancient bug in Lotus Notes #2026

bschmalhofer opened this issue Dec 1, 2022 · 2 comments
Labels
good first issue Good for newcomers tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Dec 1, 2022 •
edited
Loading

See znuny/Znuny@118db21 .
I propose to remove this workaround as my guess is that nowadays Lotus Notes, or IBM Notes, or HCL Notes, is able to understand correct HTML.

TODO:

  • remove the workaround the changes <br/> to <br />.
  • Check for fallout in the test suite
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Dec 1, 2022
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Dec 1, 2022
@bschmalhofer bschmalhofer added the good first issue Good for newcomers label Dec 1, 2022
@bschmalhofer
Copy link
Contributor Author

Did some digging and I'm fairly confident that this workaround is no longer needed:

bschmalhofer added a commit that referenced this issue Nov 17, 2023
@bschmalhofer
Issue #2026: remove workaround for Lotus Notes
dbbe573 
Nowadays called HCL Notes
bschmalhofer added a commit that referenced this issue Nov 17, 2023
@bschmalhofer
Merge pull request #2691 from RotherOSS/issue-#2026-hcl_notes
670c96f 
Issue #2026: remove workaround for Lotus Notes
@bschmalhofer
Copy link
Contributor Author

Tests look fine. PR is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer