Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTest Failure in AdminProcessManagementTransitionAction.t #2029

Closed
stefanhaerter opened this issue Dec 2, 2022 · 4 comments
Closed

UnitTest Failure in AdminProcessManagementTransitionAction.t #2029

stefanhaerter opened this issue Dec 2, 2022 · 4 comments
Assignees
Labels
selenium Related to fixing or improving testing with Selenium

Comments

@stefanhaerter
Copy link
Contributor

stefanhaerter commented Dec 2, 2022

The test scripts/test/Selenium/Agent/Admin/ProcessManagement/AdminProcessManagementTransitionAction.t fails, at least when running the whole directory of tests (bin/otobo.Console.pl Dev::UnitTest::Run --directory Agent/Admin/ProcessManagement). It seems that this is due to the test relying on behaviour prior to #1565. The test should be adjusted accordingly.

@stefanhaerter stefanhaerter added the selenium Related to fixing or improving testing with Selenium label Dec 2, 2022
@stefanhaerter stefanhaerter self-assigned this Dec 2, 2022
@bschmalhofer
Copy link
Contributor

@stefanhaerter, @svenoe Can this be included with OTOBO 10.18 ? It would be nice to have a test suite without failures.

@stefanhaerter
Copy link
Contributor Author

I have already worked on that test, but I'm unsure whether my solution is a good way to address this. Maybe we could find some time to look at it together?

@stefanhaerter
Copy link
Contributor Author

I pushed a fix which relies on a certain order of values. However, after some discussing @bschmalhofer and I consider the alphabetical sorting of keys in an existing transition action, which diverges from the original sorting in a new transition action, a bug which should be fixed. The fixed test is expected to fail when the bug is fixed, so it has to be adjusted again.

stefanhaerter added a commit that referenced this issue Feb 20, 2023
bschmalhofer added a commit that referenced this issue Feb 20, 2023
…ion_action_test

Issue #2029 adjusting transition action test
@bschmalhofer
Copy link
Contributor

PR is merged. The test suite looks fine. Closing this issue.

Test Summary Report
-------------------
/opt/otobo/scripts/test/Compile.t                                                                         (Wstat: 0 Tests: 1785 Failed: 0)
  TODO passed:   1147, 1244
/opt/otobo/scripts/test/Selenium/TestingMethods.t                                                         (Wstat: 0 Tests: 36 Failed: 0)
  TODO passed:   21, 24, 28
Files=964, Tests=81147, 5987 wallclock secs (27.96 usr  3.50 sys + 1613.13 cusr 229.22 csys = 1873.81 CPU)
Result: PASS
ran tests for product OTOBO 10.1.x on host ffda6b56f95f .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selenium Related to fixing or improving testing with Selenium
Projects
None yet
Development

No branches or pull requests

2 participants