Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with CodePolicy regarding heredocs #2086

Closed
1 task done
bschmalhofer opened this issue Jan 9, 2023 · 1 comment
Closed
1 task done

Comply with CodePolicy regarding heredocs #2086

bschmalhofer opened this issue Jan 9, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0.1

Comments

@bschmalhofer
Copy link
Contributor

bschmalhofer commented Jan 9, 2023 •
edited
Loading

The Perl::Critic checks of heredocs were tightened. See https://github.com/RotherOSS/CodePolicy/issues/91.
TODO:

  • handle the new complaints
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jan 9, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Jan 9, 2023
@bschmalhofer bschmalhofer self-assigned this Jan 9, 2023
bschmalhofer added a commit that referenced this issue Jan 9, 2023
@bschmalhofer
Issue #2086: adapt heredoc delimiter
8895325
bschmalhofer added a commit that referenced this issue Jan 9, 2023
@bschmalhofer
Issue #2086: do not separate statements by comma
a274b23
bschmalhofer added a commit that referenced this issue Jan 9, 2023
@bschmalhofer
Merge pull request #2087 from RotherOSS/issue-#2086-heredocs
bc19888 
Issue #2086 heredocs
@bschmalhofer
Copy link
Contributor Author

PR is merged. No more complaints about heredocs from CodePolicy. Closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.1 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer