Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for CommunicationID in Kernel::System::CommunicationLog::DB::ObjectLookupGet() #2089

Closed
bschmalhofer opened this issue Jan 11, 2023 · 2 comments
Closed

Remove support for CommunicationID in Kernel::System::CommunicationLog::DB::ObjectLookupGet() #2089

bschmalhofer opened this issue Jan 11, 2023 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 10.1.7

Comments

@bschmalhofer
Copy link
Contributor

That the undocumented parameter CommunicationID is used in Kernel::System::CommunicationLog::DB::ObjectLookupGet() looks like an oversight in the original implementation. See
OTRS/otrs@0a81ebb#diff-0909aeec160a8765a3ef724f9fd01e588fa52eb134bc214186736fbb3f65e133

Also check wheter the calls to ObjectLookupGet() pass sane parameters.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jan 11, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Jan 11, 2023
@bschmalhofer bschmalhofer self-assigned this Jan 11, 2023
@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 10.1.7 Jan 11, 2023
@bschmalhofer
Copy link
Contributor Author

See also #2037 .

bschmalhofer added a commit that referenced this issue Jan 11, 2023
@bschmalhofer
Issue #2089: enhance POD of Kernel::System::CommunicationLog::new()
ecac77d 
The parameter ObjectLogID is also supported.
undef can be returned.
bschmalhofer added a commit that referenced this issue Jan 11, 2023
@bschmalhofer
Issue #2089: enhance POD and code comments
8e0e2b7 
also some minor code cleanups
bschmalhofer added a commit that referenced this issue Jan 11, 2023
@bschmalhofer
Issue #2089: remove support for parameter CommunicationID
62d6a08 
in Kernel::System::CommunicationLog::ObjectLookupGet() as the
parameter was neiter documented nor used.
bschmalhofer added a commit that referenced this issue Jan 11, 2023
@bschmalhofer
Issue #2089: satisfy the CodePolicy
885c24b 
stringy splits are prohibited
bschmalhofer added a commit that referenced this issue Jan 11, 2023
@bschmalhofer
Merge pull request #2091 from RotherOSS/issue-#2089-communication_id
60f137b 
Issue #2089 communication
@bschmalhofer
Copy link
Contributor Author

PR is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.1.7
Development

No branches or pull requests
1 participant
@bschmalhofer