Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with Perl:Critic policy Variables::RequireInitializationForLocalVars #2116

Closed
bschmalhofer opened this issue Jan 16, 2023 · 2 comments
Closed

Comply with Perl:Critic policy Variables::RequireInitializationForLocalVars #2116

bschmalhofer opened this issue Jan 16, 2023 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0.1

Comments

@bschmalhofer
Copy link
Contributor

This policy has been added to CodePolicy in https://github.com/RotherOSS/CodePolicy/issues/99.See also https://metacpan.org/pod/Perl::Critic::Policy::Variables::RequireInitializationForLocalVars .
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jan 16, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Jan 16, 2023
@bschmalhofer bschmalhofer self-assigned this Jan 16, 2023
@bschmalhofer
Copy link
Contributor Author

A common usage is local *STDOUT; for temporarily overriding standard file handles. Rewriting that to local *STDOUT = undef emits a waring, https://perldoc.perl.org/perldiag#Undefined-value-assigned-to-typeglob. The alternative local *STDOUT = *funny_name is too strange. So let's settle with the a bit loss awkward local *STDOUT; ## no critic qw(Variables::RequireInitializationForLocalVars). Ultimately something like IO::Capture should be used for these cases.

bschmalhofer added a commit that referenced this issue Jan 16, 2023
@bschmalhofer
Issue #2116: avoid violations of Variables::RequireInitializationForL…
0a5559c 
…ocalVars

Either with a 'no critic' directive
or by assigning a value in same line as declaration with 'local'.
bschmalhofer added a commit that referenced this issue Jan 16, 2023
@bschmalhofer
Merge pull request #2118 from RotherOSS/issue-#2116-local_vars
0de23d8 
Issue #2116: avoid violations of Variables::RequireInitializationForL…
bschmalhofer added a commit that referenced this issue Jan 16, 2023
@bschmalhofer
Issue #2116: avoid of assignments of undefined values
5318bb3 
as these cause warnings.
bschmalhofer added a commit that referenced this issue Jan 16, 2023
@bschmalhofer
Merge pull request #2119 from RotherOSS/issue-#2116-on_warnings
341cedb 
Issue #2116: avoid of assignments of undefined values
@bschmalhofer
Copy link
Contributor Author

CodePolicy is satisfied again, the test suite looks fine, closing this issue

@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.1 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer