Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After activating the Config parameter "CloseParentAfterClosedChilds" only the button "Close" is hidden. #2131

Closed
KhalilHamada-OTOBO opened this issue Jan 20, 2023 · 5 comments
Closed

After activating the Config parameter "CloseParentAfterClosedChilds" only the button "Close" is hidden. #2131

KhalilHamada-OTOBO opened this issue Jan 20, 2023 · 5 comments
Assignees
@stefanhaerter
Labels
bug Something isn't working as intended

Comments

@KhalilHamada-OTOBO
Copy link
Contributor

After activating the Config parameter "CloseParentAfterClosedChilds" only the button "Close" is hidden. And the button "Quick Close" is not hidden!

https://portal.rother-oss.com/otobo/index.pl?Action=AgentTicketZoom;TicketID=49729
@KhalilHamada-OTOBO KhalilHamada-OTOBO added the bug Something isn't working as intended label Jan 20, 2023
@stefanhaerter
Copy link
Contributor

Taking a quick look, I would assume that this is due to the following line not including AgentTicketQuickClose:

otobo/Kernel/System/Ticket/Acl/CloseParentAfterClosedChilds.pm

Line 110 in 99a57cf

Action => ['AgentTicketClose'],

stefanhaerter added a commit that referenced this issue Jan 20, 2023
@stefanhaerter
Issue #2131: Also hide quick close button when acl CLoseParentAfterCl…
435b29e 
…osedChilds is activated.
@stefanhaerter stefanhaerter mentioned this issue Jan 20, 2023
Merged
svenoe pushed a commit that referenced this issue Feb 9, 2023
@stefanhaerter @svenoe
Issue #2131: Also hide quick close button when acl CLoseParentAfterCl…
1a2efab 
…osedChilds is activated.
@svenoe svenoe closed this as completed Feb 9, 2023
@bschmalhofer
Copy link
Contributor

I suspect that this change broke the unit test script scripts/test/Ticket/TicketACL/CloseParentAfterCloseChilds.t:

ok 65 - Open Child - Action: 'AgentTicketProcess' should not be undefined in the ACL
ok 66 - Open Child - Action: 'AgentTicketQueue' should not be undefined in the ACL
not ok 67 - Open Child - Action: 'AgentTicketQuickClose' should not be undefined in the ACL (is 'undef')
ok 68 - Open Child - Action: 'AgentTicketResponsible' should not be undefined in the ACL
ok 69 - Open Child - Action: 'AgentTicketResponsibleView' should not be undefined in the ACL

My guess is that the test script must be updated to reflect the changed behavior.

@stefanhaerter, could you investigate this?

@bschmalhofer bschmalhofer reopened this Feb 11, 2023
stefanhaerter added a commit that referenced this issue Feb 13, 2023
@stefanhaerter
Issue #2131: Adding AgentTicketQuickClose to blacklisted actions in c…
57b7560 
…orresponding unit test.
@stefanhaerter
Copy link
Contributor

It looks like you're right. I made a PR and added AgentTicketQuickClose to the blacklisted actions in the unit test, which should fix the test.

bschmalhofer added a commit that referenced this issue Feb 13, 2023
@bschmalhofer
Merge pull request #2164 from RotherOSS/issue-#2131-fixing-unit-test
1cd095e 
Issue #2131: Adding AgentTicketQuickClose to blacklisted actions in c…
@bschmalhofer
Copy link
Contributor

PR is applied. Closing this issue after the next successful run of the test suite.

@bschmalhofer
Copy link
Contributor

The test suite looks fine again. Closing this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanhaerter stefanhaerter

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bschmalhofer @stefanhaerter @svenoe @KhalilHamada-OTOBO