Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidying of Layout.pm #2396

Closed
bschmalhofer opened this issue Jul 14, 2023 · 1 comment
Closed

Tidying of Layout.pm #2396

bschmalhofer opened this issue Jul 14, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0.1

Comments

@bschmalhofer
Copy link
Contributor

Just some cleanup of code in Kernel/Output/HTML/Layout.pm. This is in a dedicated issue, because it does not fit in with any other open issue.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jul 14, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0.1 milestone Jul 14, 2023
@bschmalhofer bschmalhofer self-assigned this Jul 14, 2023
bschmalhofer added a commit that referenced this issue Jul 14, 2023
@bschmalhofer
Issue #2396: improve POD and code comments
99d7992
bschmalhofer added a commit that referenced this issue Jul 14, 2023
@bschmalhofer
Issue #2396: minor tidying
5fbe3cd
bschmalhofer added a commit that referenced this issue Jul 14, 2023
@bschmalhofer
Issue #2396: remove unused variable $TextScalar
a1fb3c3
bschmalhofer added a commit that referenced this issue Jul 14, 2023
@bschmalhofer
Issue #2396: no need to work with a hash reference
b63cd65 
in _BuildSelectionAttributeRefCreate()
bschmalhofer added a commit that referenced this issue Jul 14, 2023
@bschmalhofer
Issue #2396: try to tidy _BuildSelectionOutput()
2c367a9 
Avoid messy concatenations to the result string.
Instead collect the needed parts and the assemble in on go.
bschmalhofer added a commit that referenced this issue Jul 14, 2023
@bschmalhofer
Merge pull request #2397 from RotherOSS/issue-#2396-layout_pm
13c2517 
Issue #2396 layout pm
@bschmalhofer
Copy link
Contributor Author

PR is merged. Hoping for the best and closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer