Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent use of Scalar::Util #2404

Closed
bschmalhofer opened this issue Jul 19, 2023 · 1 comment
Closed

Consistent use of Scalar::Util #2404

bschmalhofer opened this issue Jul 19, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

There are some inconsistencies in how functions from Scalar::Util are handled. The usage should follow these rules:

  • don't load Scalar::Util unless needed
  • load Scalar::Util when need
  • Import the needed funktions into the current namespace, don't use namespaced calls

Note that Scalar::Util exports no functions per default.
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Jul 19, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Jul 19, 2023
@bschmalhofer bschmalhofer self-assigned this Jul 19, 2023
bschmalhofer added a commit that referenced this issue Jul 21, 2023
@bschmalhofer
Issue #2404: consisten use of Scalar::Util::weaken
6976ef4
bschmalhofer added a commit that referenced this issue Jul 21, 2023
@bschmalhofer
Issue #2404: consisten use of Scalar::Util::blessed
e6b3f10
bschmalhofer added a commit that referenced this issue Jul 21, 2023
@bschmalhofer
Issue #2404: eliminate not needed 'use Scalar::Util'
75bca39 
this is save as Scalar::Util imports no functions per default
bschmalhofer added a commit that referenced this issue Jul 21, 2023
@bschmalhofer
Merge pull request #2408 from RotherOSS/issue-#2404-scalar_util
d6b684c 
Issue #2404 scalar util
@bschmalhofer
Copy link
Contributor Author

Unittests are fine. PR is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer