Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer use internally the name slave DB for the mirror DB #2431

Closed
bschmalhofer opened this issue Aug 4, 2023 · 2 comments
Closed

No longer use internally the name slave DB for the mirror DB #2431

bschmalhofer opened this issue Aug 4, 2023 · 2 comments
Assignees
Labels
tidying Tidying of the code
Milestone

Comments

@bschmalhofer
Copy link
Contributor

One or more mirror databases can be set up to provide separate databases that can be used for reporting. This avoids a slowdown of OTOBO when reports, or statistics, are generated.
The config settings for the mirror database have the prefix Core::MirrorDB::. This is fine. But internally the name slave DB is still used. Most of the usage can be adapted in Kernel/System/DB.pm . One exception is the package variable Kernel::System::DB::UseSlaveDB which is used in OTOBO core and can be used in OTOBO packages.

I suggest to rename the internal variables and the package variable in OTOBO core. For the packages there are two options:

  • still support the legacy name UseSlaveDB
  • force a renaming when packages are adapted for OTOBO 11
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Aug 4, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Aug 4, 2023
@bschmalhofer bschmalhofer self-assigned this Aug 4, 2023
@bschmalhofer
Copy link
Contributor Author

Talked with @svenoe : renaming the global variable is fine

bschmalhofer added a commit that referenced this issue Aug 7, 2023
Packages that want to query the mirror database need to set
$Kernel::System::DB::UseMirrorDB in OTOBO 11.0.x
bschmalhofer added a commit that referenced this issue Aug 7, 2023
@bschmalhofer
Copy link
Contributor Author

Merged the PR. Note that most of the commit were attached to #2430 because the changes were initially made in a branch for that issue.
Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidying Tidying of the code
Projects
None yet
Development

No branches or pull requests

1 participant