Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Encode::Locale::decode_argv in Encode.pm #2436

Closed
bschmalhofer opened this issue Aug 6, 2023 · 2 comments
Closed

Use Encode::Locale::decode_argv in Encode.pm #2436

bschmalhofer opened this issue Aug 6, 2023 · 2 comments
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

In the constructor of Kernel::System::Encode there is support for decoding @argv. This code is fine. A slight tidying is to use the funcion decode_argv() for that . See https://metacpan.org/pod/Encode::Locale#decode_argv(-)
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Aug 6, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Aug 6, 2023
@bschmalhofer bschmalhofer self-assigned this Aug 6, 2023
@bschmalhofer
Copy link
Contributor Author

It's a bit cleaner, let's do it.

bschmalhofer added a commit that referenced this issue Aug 7, 2023
@bschmalhofer
Issue #2436: a bit of tidying
cff56fc 
Code comments, empty lines aroud control flow statements
bschmalhofer added a commit that referenced this issue Aug 7, 2023
@bschmalhofer
Issue #2436: use Encode::Locale::decode_argv()
b28ce5a 
for decoding the command line parameters
bschmalhofer added a commit that referenced this issue Aug 7, 2023
@bschmalhofer
Merge pull request #2438 from RotherOSS/issue-#2436-decode_argv
7c3d6a8 
Issue #2436 decode argv
@bschmalhofer
Copy link
Contributor Author

A quick test of a console command and of the web interface looked fine. PR is applied. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer