Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convenience method DoArray() to Kernel::System::DB #2447

Closed
bschmalhofer opened this issue Aug 8, 2023 · 3 comments
Closed

Add convenience method DoArray() to Kernel::System::DB #2447

bschmalhofer opened this issue Aug 8, 2023 · 3 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

Sometimes it is convenient to insert, update or delete several rows in on statement. For that purpose, DBI provides the method execute_array(). This method accepts arrrayrefs as bind variables. This functionality can be made available to OTOBO via the new method Kernel::System::DB::DoArray().
@bschmalhofer bschmalhofer added the enhancement New feature or request label Aug 8, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Aug 8, 2023
@bschmalhofer bschmalhofer self-assigned this Aug 8, 2023
bschmalhofer added a commit that referenced this issue Aug 8, 2023
@bschmalhofer
Issue #2447: add the method DoArray()
17945b1
bschmalhofer added a commit that referenced this issue Aug 8, 2023
@bschmalhofer
Merge pull request #2448 from RotherOSS/issue-#2447-do_array
73017fe 
Issue #2447: add the method DoArray()
@bschmalhofer bschmalhofer changed the title Add convenience metho DoArray() to Kernel::System::DB Add convenience method DoArray() to Kernel::System::DB Aug 8, 2023
@bschmalhofer
Copy link
Contributor Author

PR is merged, but let's keep this issue open in case the implementation needs to be enhanced.

bschmalhofer added a commit that referenced this issue Aug 10, 2023
@bschmalhofer
Issue #2447: simple scalars as bind variable in DoArray()
f328161 
The scalar will be used for all relevant rows.
bschmalhofer added a commit that referenced this issue Aug 10, 2023
@bschmalhofer
Issue #2447: tentatively support ArrayTupleFetch
185c45e 
this is still untested
bschmalhofer added a commit that referenced this issue Aug 10, 2023
@bschmalhofer
Issue #2447: fix a small but significant type
be5b4c2
bschmalhofer added a commit that referenced this issue Aug 10, 2023
@bschmalhofer
Merge pull request #2456 from RotherOSS/issue-#2447-do_array
f868cf5 
Issue #2447 do array
@bschmalhofer
Copy link
Contributor Author

bschmalhofer commented Aug 10, 2023 •
edited
Loading

TODO:

  • allow a non-ref scalar as bind variable
  • add test for DoArray() with ArrayTupleFetch
  • go over the documentation, mention how to handle errors

bschmalhofer added a commit that referenced this issue Aug 11, 2023
@bschmalhofer
Issue #2447: add POD for ArrayTupleFetch
8f90670
bschmalhofer added a commit that referenced this issue Aug 11, 2023
@bschmalhofer
Issue #2447: make returned value context independent
8c51a7e 
that is, force scalar context when calling execute_array()
bschmalhofer added a commit that referenced this issue Aug 11, 2023
@bschmalhofer
Issue #2447: add test for ArrayTupleFetch
d71e2ea
bschmalhofer added a commit that referenced this issue Aug 11, 2023
@bschmalhofer
Merge pull request #2457 from RotherOSS/issue-#2447-array_tuple_fetch
be4b4a2 
Issue #2447 array tuple fetch
@bschmalhofer
Copy link
Contributor Author

ArrayTupleFetch is now working too. Closing this issue.

bschmalhofer added a commit that referenced this issue Sep 22, 2023
@bschmalhofer
Issue #2447: tests with bind variables
e1c5fec
bschmalhofer added a commit that referenced this issue Sep 22, 2023
@bschmalhofer
Issue #2447: tests for Prepare()
1179faf 
where Execute => 0 was passed
bschmalhofer added a commit that referenced this issue Sep 22, 2023
@bschmalhofer
Issue #2447: enhance the POD of Prepare()
f7b8006
bschmalhofer added a commit that referenced this issue Sep 22, 2023
@bschmalhofer
Issue #2447: simplify Prepare()
a8b532f 
There is no need to call Prepar() in list context,
even for the 'Execute => 0' case.
Change because strange effects have been reported.
bschmalhofer added a commit that referenced this issue Sep 22, 2023
@bschmalhofer
Issue #2447: simplify Prepare()
375a014 
There is no need to call Prepare() in list context,
even in the 'Execute => 0' case.
Changed because strange effects have been reported.
bschmalhofer added a commit that referenced this issue Sep 22, 2023
@bschmalhofer
Merge pull request #2521 from RotherOSS/issue-#2447-execute_0_take_2
a41285f 
Issue #2447 execute 0 take 2
bschmalhofer added a commit that referenced this issue Sep 23, 2023
@bschmalhofer
Issue #2447: emphasize the case where Prepare() returns an arrayref
ac3e50f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer