Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Lint the Dockerfile #246

Closed
bschmalhofer opened this issue Jul 24, 2020 · 4 comments
Closed

Docker: Lint the Dockerfile #246

bschmalhofer opened this issue Jul 24, 2020 · 4 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.1.1

Comments

@bschmalhofer
Copy link
Contributor

See https://stackoverflow.com/questions/28182047/is-there-a-way-to-lint-the-dockerfile .
@bschmalhofer bschmalhofer added the enhancement New feature or request label Jul 24, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Jul 24, 2020
bschmalhofer added a commit that referenced this issue Sep 3, 2020
@bschmalhofer
Issue #246: add script for linting docker files
eda2d88
bschmalhofer added a commit that referenced this issue Sep 3, 2020
@bschmalhofer
Issue #246: clean up commands for installing packages
ee67b45
bschmalhofer added a commit that referenced this issue Sep 3, 2020
@bschmalhofer
Issue #246: clean up command for the cronjobs
9201ac2
bschmalhofer added a commit that referenced this issue Sep 3, 2020
@bschmalhofer
Issue #246: USER root is set on purpose
5719412 
Because only root can start cron
@bschmalhofer
Copy link
Contributor Author

Hadolint https://github.com/hadolint/hadolint looks like a good choice for linting.
Added bin/docker/lint_docker_files.sh for running the linter.
Adapted the docker files so that hadolint is happy.
Closing the ticket when tests are successful.

@bschmalhofer
Copy link
Contributor Author

Got some test failures. Need to investigate whether these are related to the Dockerfile changes.

Test Summary Report
-------------------
scripts/test/Package/ConfiguredRepositoryDefinitionGet.t                                       (Wstat: 0 Tests: 3 Failed: 1)
  Failed test:  3
scripts/test/WebUserAgent.t                                                                    (Wstat: 65280 Tests: 44 Failed: 4)
  Failed tests:  31-32, 43-44
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
Files=949, Tests=56311, 2241 wallclock secs (10.89 usr  1.67 sys + 1091.93 cusr 117.71 csys = 1222.20 CPU)
Result: FAIL

@bschmalhofer
Copy link
Contributor Author

Same test failures were seen in rel-10_1 branch, Look like they are not related to the Dockerfile changes. Closing the issue.

@bschmalhofer
Copy link
Contributor Author

File it under milestone 10.1 as the task is already done.

@bschmalhofer bschmalhofer self-assigned this Nov 28, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.1.1 Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.1.1
Development

No branches or pull requests
1 participant
@bschmalhofer