Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add Unicode::GCString to the Docker installation #2474

Closed
bschmalhofer opened this issue Aug 16, 2023 · 1 comment
Closed

Testing: Add Unicode::GCString to the Docker installation #2474

bschmalhofer opened this issue Aug 16, 2023 · 1 comment
Assignees
Labels
docker Docker related issues unittests Requests wrt unittests

Comments

@bschmalhofer
Copy link
Contributor

The test suite uses TAP::Harnesswhich often displays information about a failed test in tabular format. That formatting uses Unicode::GCStringwhen available. When the module is not available a message about that is shown.

not ok 12 - HumanReadableDataSize: Size => 58626123, Lang => ar_SA # TODO translation should be update to say: (MB)
# Failed test (with amnesty) 'HumanReadableDataSize: Size => 58626123, Lang => ar_SA'
# at /opt/otobo/scripts/test/Layout/HumanReadableDataSize.t line 148.
# Unicode::GCString is not installed, table may not display all unicode characters properly
# +------------------------------+----+------------------------------+
# | GOT                          | OP | CHECK                        |
# +------------------------------+----+------------------------------+
# | \N{U+200E}55.9 ��غابا�ت (MG) | eq | \N{U+200E}55.9 ��غابا�ت (MB) |
# +------------------------------+----+------------------------------+

I checked the documentation of Unicode::GCString and found that installing it should show no adverse effects. So, let's eliminate a confusing message and maybe get a better display of test violations.

@bschmalhofer bschmalhofer added docker Docker related issues unittests Requests wrt unittests labels Aug 16, 2023
@bschmalhofer bschmalhofer self-assigned this Aug 16, 2023
bschmalhofer added a commit that referenced this issue Aug 16, 2023
This means that the module will be included in the Docker image
bschmalhofer added a commit that referenced this issue Aug 16, 2023
@bschmalhofer
Copy link
Contributor Author

The message "Unicode::GCString is not installed, table may not display all unicode characters properly" is gone now. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related issues unittests Requests wrt unittests
Projects
None yet
Development

No branches or pull requests

1 participant