Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate test _PDFTicket.t_ for Chromium browser #2481

Closed
bschmalhofer opened this issue Aug 18, 2023 · 1 comment
Closed

Activate test _PDFTicket.t_ for Chromium browser #2481

bschmalhofer opened this issue Aug 18, 2023 · 1 comment
Assignees
@bschmalhofer
Labels
unittests Requests wrt unittests
Milestone
OTOBO 11.0

Comments

@bschmalhofer
Copy link
Contributor

The tests in scripts/test/Selenium/Output/PDFTicket.t are skipped when the remote controlled browser is not Firefox. But the most often used browser for Selenium testing is Chromium. Let's test whether the test script works in that setting.
@bschmalhofer bschmalhofer added the unittests Requests wrt unittests label Aug 18, 2023
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Aug 18, 2023
@bschmalhofer bschmalhofer self-assigned this Aug 18, 2023
bschmalhofer added a commit that referenced this issue Sep 28, 2023
@bschmalhofer
Issue #2481: eliminate usage of $main::Self
8743766
bschmalhofer added a commit that referenced this issue Sep 28, 2023
@bschmalhofer
Issue #2481: no longer skip this test
bf7759c
bschmalhofer added a commit that referenced this issue Sep 28, 2023
@bschmalhofer
Issue #2481: do not shorten the random id for dynfields
b11e3bd 
Because there were instances where the same ID was used again.
bschmalhofer added a commit that referenced this issue Sep 28, 2023
@bschmalhofer
Issue #2481: make the Print links clickable
fa626fb 
They were not clickable as they were hidden.
bschmalhofer added a commit that referenced this issue Sep 28, 2023
@bschmalhofer
Issue #2481: declare PDF content tests as TODO
43b813f 
At least under chrome the actual content of the PDF is
not available in the page source.
bschmalhofer added a commit that referenced this issue Sep 28, 2023
@bschmalhofer
Merge pull request #2534 from RotherOSS/issue-#2481-chromium
6b46c89 
Issue #2481 chromium
@bschmalhofer
Copy link
Contributor Author

The test test script is no longer skipped, and it succeedis with the Chrome browser provided in the Docker Compose setup. The PDFs are visible when watching the test run with Remmina. However, the content of the PDF is not actually checked, as the content is not easily available in the HTML source.

Closing this issue, as the main goal was to no longer skip the test script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
unittests Requests wrt unittests
Projects
None yet
Milestone
OTOBO 11.0
Development

No branches or pull requests
1 participant
@bschmalhofer